Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
This eliminates the 250ms delay between a local task completing and the next redraw. Redraws are only triggered by messages in the queue (and not events), so we can send an empty message to trigger a redraw.
I think it'd be a good idea to make all tasks run on the main thread, since we're heavily I/O bound anyway. Should cut down on wasted effort, and eliminate the
Send
bound on everything.Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
Changes to the core of the event loop are always risky. Mitigated with a whole bunch of existing tests.
QA
How did you test this?
Hit buttons and shit
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?